This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/8] de-couple %Stop from notification: gdbserver


puOn 12/11/2012 06:40 AM, Yao Qi wrote:
> 2012-12-11  Yao Qi  <yao@codesourcery.com>
> 
> 	* Makefile.in (OBS): Add notif.o.
> 	(notif_h, queue_h): New.

Don't forget to remove this from the ChangeLog entry before
checking in, now that gdbserver tracks dependencies automatically.

> 	(notif.o): New rule.
> 
> 	* notif.c, notif.h: New.
> 	* server.c: Include "notif.h".
> 	(struct vstop_notif) <next>: Remove.
> 	<base>: New field.
> 	(queue_stop_reply): Update.
> 	(push_event, send_next_stop_reply): Remove.
> 	(discard_queued_stop_replies): Update.
> 	(notif_stop): New variable.
> 	(handle_v_stopped): Remove.
> 	(handle_v_requests): Don't call handle_v_stopped.  Call
> 	handle_ack_notif instead.
> 	(queue_stop_reply_callback): Call notif_event_enque instead
> 	of queue_stop_reply.
> 	(handle_status): Don't call send_next_stop_reply, call
> 	notif_write_event instead.
> 	(kill_inferior_callback): Likewise.
> 	(detach_or_kill_inferior_callback): Likewise.
> 	(main): Call initialize_notif.
> 	(process_serial_event): Call QUEUE_is_empty.
> 	(handle_target_event): Call notif_push instead of push event.
> 	* server.h: Remove declaration of push_event.

Write:

 	* server.h (push_event): Remove declaration.

Patch is okay.

Thanks!

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]