This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [4/8] remove call-cmds.h
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 12 Dec 2012 18:45:21 +0000
- Subject: Re: [4/8] remove call-cmds.h
- References: <87obhz6x0x.fsf@fleche.redhat.com>
On 12/12/2012 04:43 PM, Tom Tromey wrote:
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 9f6f3a9..4bd6fd9 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1135,7 +1135,7 @@ init.c: $(INIT_FILES)
> @echo '/* Do not modify this file. */' >>init.c-tmp
> @echo '/* It is created automatically by the Makefile. */'>>init.c-tmp
> @echo '#include "defs.h" /* For initialize_file_ftype. */' >>init.c-tmp
> - @echo '#include "call-cmds.h" /* For initialize_all_files. */' >>init.c-tmp
> + @echo 'extern void initialize_all_files(void);' >>init.c-tmp
Missing space before parens. :-P :-)
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -19,7 +19,6 @@
>
> #include "defs.h"
> #include "gdbcmd.h"
> -#include "call-cmds.h"
> #include "cli/cli-cmds.h"
> #include "cli/cli-script.h"
> #include "cli/cli-setshow.h"
> @@ -65,6 +64,8 @@
> #include "ui-out.h"
> #include "cli-out.h"
>
> +extern void initialize_all_files (void);
I think a small comment around something like
/* Defined in init.c (generated in the build dir). */
would be nice.
--
Pedro Alves