This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFC-v5] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior)
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Pedro Alves'" <palves at redhat dot com>
- Cc: "'GDB Patches'" <gdb-patches at sourceware dot org>
- Date: Thu, 13 Dec 2012 16:17:01 +0100
- Subject: RE: [RFC-v5] Fix .text section offset for windows DLL (was Calling __stdcall functions in the inferior)
- References: <20121024194517.GK3555@adacore.com> <011901cdb2ab$48076b90$d81642b0$@muller@ics-cnrs.unistra.fr> <20121105171121.GA2972@adacore.com> <50991f5f.8382440a.1100.ffff82abSMTPIN_ADDED@mx.google.com> <509ABA17.30507@redhat.com> <000301cdbd96$f5cd9f10$e168dd30$@muller@ics-cnrs.unistra.fr> <20121122173019.GF9964@adacore.com> <15690.5992342674$1353883881@news.gmane.org> <87624si9ur.fsf@fleche.redhat.com> <001501cdccaf$ad85e9b0$0891bd10$@muller@ics-cnrs.unistra.fr> <20121207071035.GG31477@adacore.com> <50C20A66.70002@gmail.com> <29545.4593528577$1354894901@news.gmane.org> <50C21696.7040006@gmail.com> <50c21914.a750420a.2ec3.ffffe4ffSMTPIN_ADDED_BROKEN@mx.google.com> <50C222D5.4000802@redhat.com> <50C22C20.8090906@redhat.com> <008101cdd920$907e7580$b17b6080$@muller@ics-cnrs.unistra.fr> <50C9B6E0.1050709@redhat.com> <00a201cdd931$b0ee13f0$12ca3bd0$@muller@ics-cnrs.unistra.fr> <50C9E706.2020708@redhat.com>
> >> I'm still curious on why you needed the #ifndefs though.
> >
> > Oh, I forgot that one,
> > I will test without the ifdef's...
> > These across are defined in mingw32 winnh.h header
> > and also for cygwin in
> > /usr/include/aout.h
> > /usr/include/w32api/winnt.h
> > as well as in
> > /usr/include/w32api/ddk/ntimage.h
> >
> > and I was afraid that such a header could be included indirectly
> > by some of the other headers.
>
> I don't think that's very likely. That'd mean that coff/pe.h would
> need guards for its related definitions too.
>
> > Below is a patch to remove the unneeded checks...
> >
> > 2012-12-13 Pierre Muller <muller@sourceware.org>
> >
> > * coff-pe-read.c (IMAGE_SCN_CNT_TEXT,
> IMAGE_SCN_CNT_INITIALIZED_DATA)
> > (IMAGE_SCN_CNT_UNINITIALIZED_DATA): Remove useless checks
> > for already defined macros.
> >
> > Index: coff-pe-read.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/coff-pe-read.c,v
> > retrieving revision 1.19
> > diff -u -p -r1.19 coff-pe-read.c
> > --- coff-pe-read.c 13 Dec 2012 10:44:45 -0000 1.19
> > +++ coff-pe-read.c 13 Dec 2012 12:46:09 -0000
> > @@ -55,15 +55,9 @@ struct read_pe_section_data
> > char *section_name; /* Recorded section name. */
> > };
> >
> > -#ifndef IMAGE_SCN_CNT_CODE
> > # define IMAGE_SCN_CNT_CODE 0x20
>
> The spaces in "# define" should be removed too. Okay with that change.
Thanks committed with your change applied.
And my apologies for the cross-post about the
coff/internal.h header need.
Pierre