This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [patch v6 02/12] cli, btrace: add btrace cli

From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: "palves at redhat dot com" <palves at redhat dot com>, "tromey at redhat dot com" <tromey at redhat dot com>, "kettenis at gnu dot org" <kettenis at gnu dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "markus dot t dot metzger at gmail dot com" <markus dot t dot metzger at gmail dot com>
Date: Tue, 18 Dec 2012 07:36:47 +0000
Subject: RE: [patch v6 02/12] cli, btrace: add btrace cli
References: <1355760101-26237-1-git-send-email-markus.t.metzger@intel.com> <1355760101-26237-3-git-send-email-markus.t.metzger@intel.com> <20121217183214.GA14232@host2.jankratochvil.net>

> -----Original Message-----
> From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]
> Sent: Monday, December 17, 2012 7:32 PM

Thanks for your review.

[...]

> > +  if (trace->end < trace->begin)
> > +    warning (_("Bad trace: %s - %s"), paddress (gdbarch, trace->begin),
> > +	     paddress (gdbarch, trace->end));
> 
> Shouldn't this be rather gdb_assert?  How to create such case?

I have not seen such a case, yet. This would indicate some corrupted trace buffer or problems reading the trace data correctly. It should normally not happen.

I didn't use gdb_assert since this is not checking gdb's internal state. Gdb would still function correctly even if we saw such unexpected trace.

I'm OK to change it to gdb_assert, if you want.


> No need for a repost wrt the changes above.

Does that mean you approve the patch?

Thanks,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Follow-Ups:
- Re: [patch v6 02/12] cli, btrace: add btrace cli
  - From: Jan Kratochvil

References:
- [patch v6 00/12] branch tracing support for Atom
  - From: markus . t . metzger
- [patch v6 02/12] cli, btrace: add btrace cli
  - From: markus . t . metzger
- Re: [patch v6 02/12] cli, btrace: add btrace cli
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]