This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 18 Dec 2012 09:26:56 -0700
- Subject: Re: [RFA/OBVIOUS?] ui_file_new function missing "extern" in header.
- References: <20105.7837847204$1355819774@news.gmane.org>
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> This is both a RFA
Pierre> and a question about:
Pierre> should this be considered as an obvious fix?
Pierre> i.e. shouldn't all functions declared in headers
Pierre> have the extern modifier?
Pierre> Is this mandatory?
It isn't mandatory right now, gdb does it both ways. I don't really
care about this issue so I just tend to use whatever is used nearby. I
think Joel at least has argued for making this part of the gdb style.
Tom