This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove pre_expand_symtabs_matching quick_symbol_functions API
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org, tromey at redhat dot com, ccoutant at google dot com, saugustine at google dot com
- Date: Tue, 1 Jan 2013 20:22:35 +0100
- Subject: Re: [RFA] Remove pre_expand_symtabs_matching quick_symbol_functions API
- References: <yjt2obhnfiwq.fsf@ruffy2.mtv.corp.google.com>
On Fri, 21 Dec 2012 17:51:17 +0100, Doug Evans wrote:
> Ok to check in?
> [Or am I missing something ...]
I do not see anything.
> ! /* Struct used to manage iterating over all CUs looking for a symbol. */
> !
> ! struct dw2_symtab_iterator
> {
> ! struct mapped_index *index;
> ! int want_specific_block;
> ! int block_index;
> ! domain_enum domain;
> ! offset_type *vec;
> ! int next;
> ! int length;
Here could be some more comments for the fields...
> ! };
>
> ! /* Initialize the index symtab iterator IT.
s/IT/ITER/
> ! If WANT_SPECIFIC_BLOCK is non-zero, only look for symbols
> ! in block BLOCK_KIND. */
s/BLOCK_KIND/BLOCK_INDEX/
Maybe more comments, such as that BLOCK_INDEX is valid only if
WANT_SPECIFIC_BLOCK.
>
> static void
> ! dw2_symtab_iter_init (struct dw2_symtab_iterator *iter,
> ! struct mapped_index *index,
> ! int want_specific_block,
> ! int block_index,
> ! domain_enum domain,
> ! const char *name)
> ! {
[...]
> ! while ((per_cu = dw2_symtab_iter_next (&iter)) != NULL)
This is against the GNU Coding Standards as discussed now.
Thanks,
Jan