[RFA/commit+NEWS 1/2] Add command set/show debug unwind.

[Joel Brobecker <brobecker at adacore dot com>]

Hello,

This patch adds a new debug setting to be used by frame unwinders.
It should be relatively straightforward.

gdb/ChangeLog:

        * frame-unwind.h (unwind_debug): Declare.
        * frame-unwind.c: #include "command.h" and "gdbcmd.h".
        (unwind_debug): New global.
        (show_unwind_debug): New function.
        (_initialize_frame_unwind): Add "set/show debug unwind"
        commands.

        * NEWS: Add entry for new "set/show debug unwind" commands.

gdb/doc/ChangeLog:

        * gdb.texinfo (Debugging Output): Document the new
        "set/show debug unwind" commands.

Will commit in a couple of days, if no objection.

---
 gdb/NEWS            |    4 ++++
 gdb/doc/gdb.texinfo |    5 +++++
 gdb/frame-unwind.c  |   26 ++++++++++++++++++++++++++
 gdb/frame-unwind.h  |    4 ++++
 4 files changed, 39 insertions(+)

diff --git a/gdb/NEWS b/gdb/NEWS
index 36bbd12..3451505 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -84,6 +84,10 @@ set debug notification
 show debug notification
   Control display of debugging info for async remote notification.
 
+set debug unwind
+show debug unwind
+  Control display of debugging info for some unwinders.
+
 * Removed commands
 
   ** For the Renesas Super-H architecture, the "regs" command has been removed
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index f973263..f6fb342 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -22046,6 +22046,11 @@ message.
 @item show debug timestamp
 Displays the current state of displaying timestamps with @value{GDBN}
 debugging info.
+@item set debug unwind
+@cindex unwinding debugging info
+Turns on or off display debugging info from some unwinders.
+@item show debug unwind
+Display the current state of displaying unwind debugging info.
 @item set debugvarobj
 @cindex variable object debugging info
 Turns on or off display of @value{GDBN} variable object debugging
diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c
index b66febf..7a9f6a2 100644
--- a/gdb/frame-unwind.c
+++ b/gdb/frame-unwind.c
@@ -27,6 +27,8 @@
 #include "exceptions.h"
 #include "gdb_assert.h"
 #include "gdb_obstack.h"
+#include "command.h"
+#include "gdbcmd.h"
 
 static struct gdbarch_data *frame_unwind_data;
 
@@ -237,6 +239,20 @@ frame_unwind_got_address (struct frame_info *frame, int regnum,
   return reg_val;
 }
 
+/* Flag to control frame-unwind debugging.  */
+
+int unwind_debug;
+
+/* Implement the "show debug unwind" command.  */
+
+static void
+show_unwind_debug (struct ui_file *file, int from_tty,
+		   struct cmd_list_element *c, const char *value)
+{
+  fprintf_filtered (file, _("unwind debugging is %s.\n"), value);
+}
+
+
 /* -Wmissing-prototypes */
 extern initialize_file_ftype _initialize_frame_unwind;
 
@@ -244,4 +260,14 @@ void
 _initialize_frame_unwind (void)
 {
   frame_unwind_data = gdbarch_data_register_pre_init (frame_unwind_init);
+
+  add_setshow_zinteger_cmd ("unwind", class_maintenance, &unwind_debug,
+			    _("Set unwind debugging."),
+			    _("Show unwind debugging."),
+			    _("When non-zero, frame specific internal "
+			      "debugging is enabled."),
+			    NULL,
+			    show_unwind_debug,
+			    &setdebuglist, &showdebuglist);
+
 }
diff --git a/gdb/frame-unwind.h b/gdb/frame-unwind.h
index 91ccf8c..0471730 100644
--- a/gdb/frame-unwind.h
+++ b/gdb/frame-unwind.h
@@ -30,6 +30,10 @@ struct value;
 
 #include "frame.h"		/* For enum frame_type.  */
 
+/* Flag to control frame-unwind debugging.  */
+
+extern int unwind_debug;
+
 /* The following unwind functions assume a chain of frames forming the
    sequence: (outer) prev <-> this <-> next (inner).  All the
    functions are called with this frame's `struct frame_info' and
-- 
1.7.10.4