This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [obv] Make 'disable_display' static.


Tom Tromey wrote:
> In fact I think it is better to have the discussion around exporting
> objects than around making them static.  The default ought to be
> static, as much as possible, to reduce the size of a module's API.

I agree.  Aside from what Tom said, making functions static marks them
as local.  If I touch some code using a static function I tend to look
into it a bit more--how many times is it used, can I refactor it, might
I change the parameters to save work, that kind of thing.  I tend not
to do this kind of investigation for external functions unless I have
a very compelling reason.

Cheers,
Gary

-- 
http://gbenson.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]