This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 3/5] New port: CR16: gdb port


> Thanks for spending time on this. I have tried to address all your 
> points in this updated patch.

And I confirm you did :).

> 2013-01-18 Kaushik Phatak  <kaushik.phatak@kpitcummins.com>
> 	gdb/Changelog
> 	* configure.tgt: Handle cr16*-*-*linux and cr16*-*-*.
> 	* cr16-linux-tdep.c: New file.
> 	* cr16-tdep.c: New file.
> 	* cr16-tdep.h: New file.

Looks good to me.

One warning, though: You added src/configure.ac and src/configure
to the patch. JIC we hadn't mentioned this, this part is controlled
by GCC, and needs to be approved there. You can go ahead and commit
the GDB part.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]