This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/9] bp_location.source_file -> bp_location.symtab
On Fri, 18 Jan 2013 13:59:23 +0100, Joel Brobecker wrote:
> > - /* Source file name of this address. */
> > + /* Source file name which was used to place this location. */
> >
> > - char *source_file;
> > + struct symtab *symtab;
> > };
>
> One thing, though. Why preserve "file name" in the comment, since
> this no longer is a filename?
But it is currently used only for the filename.
The code is sometimes also looking up bp_location address -> symbol and using
its symtab (update_static_tracepoint) and I did not want to dig so deep in
this patch. Use for the source file name works fine, some possible
generalization could be done elsewhere (but I do not see it much needed).
THanks,
Jan