This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 25 Jan 2013 15:29:51 +0100
Subject: Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
References: <20130117222242.GG16249@host2.jankratochvil.net> <87ip6q1gbo.fsf@fleche.redhat.com> <20130124215609.GA31688@host2.jankratochvil.net> <87fw1pl4lb.fsf@fleche.redhat.com>

On Fri, 25 Jan 2013 15:28:16 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Tom> This spot still uses symtab->filename directly.
> Tom> Is that intentional?  If so I think it should perhaps have a comment.
> 
> Jan> Yes.
> Jan> +         /* Check first sole SYMTAB->FILENAME.  It does not need to be
> Jan> +            a substring of symtab_to_fullname as it may contain "./" etc.  */
> 
> Sorry, missed that.

It was a missing comment from me, I just agreed by "Yes." there should be
a comment and so I created a new comment on the local branch to be posted
later.

Thanks for the suggestion.


Jan

References:
- [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Jan Kratochvil
- Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Tom Tromey
- Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Jan Kratochvil
- Re: [patch 6/9] Mechanical symtab->filename -> symtab_to_filename
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]