Re: [patchv3 12/11] New options {relative,basename}-with-system-absolute

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed, 30 Jan 2013 08:48:20 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -115,7 +115,8 @@ show print type typedefs
>    Control whether typedef definitions are displayed by "ptype".
>    The default is to show them.
>  
> -set filename-display basename|relative|absolute
> +set filename-display basename|relative|absolute|relative-with-system-absolute
> +                     |basename-with-system-absolute

Can't say I like these too-old names.

Otherwise, OK for this part.

> +@item set filename-display relative-with-system-absolute
> +Determine whether a source filename comes from file having separate debug
> +information file.  In such case display the source filename as absolute one.
> +Otherwise display it relative to the compilation directory.

The option controls how file names are displayed, so starting its
description with "Determine ..." is not the best way.  That first
sentence got me puzzled for a few seconds.

I suggest something like this:

  Display as absolute those source file names that come from files
  with separate debug info, and all the other source file names as
  relative to their compilation directory.

> +@item set filename-display basename-with-system-absolute
> +Determine whether a source filename comes from file having separate debug
> +information file.  In such case display the source filename as absolute one.
> +Otherwise display only basename of the filename.

Similarly here: start with "Display ..." as this what the option
controls.

> +Files having separate debug information file are expected to come from system
> +shared libraries.

This repetition is unnecessary.

OK with these changes.

Thanks.