This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] revised FreeBSD PowerPC support


On 04.02.13 19:59, Mark Kettenis wrote:
>> Date: Mon, 04 Feb 2013 18:13:38 +0000
>> From: Pedro Alves <palves@redhat.com>
>>
>> On 02/01/2013 09:51 PM, Andreas Tobler wrote:
>>> Index: ./ppcfbsd-tdep.h
>>> --- /dev/null
>>> +++ ./ppcfbsd-tdep.h
>>> @@ -0,0 +1,33 @@
>> ...
>>> +
>>> +/* FreeBSD target descriptions.  */
>>> +extern struct target_desc *tdesc_powerpc_32l;
>>> +extern struct target_desc *tdesc_powerpc_64l;
>>
>> These look stale.
>>
>> Otherwise looks good to me.
> 
> Didn't spot those.  But the diff looks sane to me as well.
> 
> 

Given the above hint and the one from Joel regarding the mh copyright
with # I take it as ok to commit? If so, do I have to wait or can I
commit immediately? (Branching?)

Thank you all for the comments.
Andreas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]