This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble
On 02/06/2013 07:58 PM, Tom Tromey wrote:
>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>
> Siva> +struct ui_out *py_out;
>
> I'd rather avoid new globals, and I don't see what this one adds.
Perhaps it is global as ui_out structures are a finite resource? See
ui-out.c:
/* Maintain a stack so that the info applicable to the inner most list
is always available. Stack/nested level 0 is reserved for the
top-level result. */
enum { MAX_UI_OUT_LEVELS = 8 };
I think we already run into this with recursive inferior function
calls in a python pretty printer:
http://sourceware.org/bugzilla/show_bug.cgi?id=10344
But, caveats galore, I have no had time to truly look at the patch.
Just a passing thought.
Cheers,
Phil