Re: [RFC/TileGX 3/6]fix syscall restart for hand call

[Joel Brobecker <brobecker at adacore dot com>]

>     all fixed, is the updated patch OK?

The patch is OK, but same remark as before regarding the missing
ChangeLog. Taking the original one:

|       * tilegx-tdep.c (tilegx_write_pc): New function.
|       prevent kernel from restarting syscall for gdb hand call.
|       (tilegx_cannot_reference_register): Likewise.
|       (tilegx_gdbarch_init): Likewise.
|       (tilegx_register_name): Likewise.
|       * tilegx-tdep.h (enum tilegx_regnum): Update.
|       * tilegx-linux-tdep.c (tilegx_linux_supply_regseit): Likewise.
|       * tilegx-linux-nat.c (regmap): Update.

For tilegx_write_pc, it is sufficient to say "New function.
However, for tilegx_cannot_reference_register, you need to be
more specific. You also forgot the INT_SWINT_1_SIGRETURN macro.

You also need to be more specific about WHAT actual change you
are making, not the general purpose of the change. And try to
also watch out for typos in the entity names, as they prevent
us from grepping for them later on, when we do some archeology.

Suggest:

        * tilegx-tdep.c (INT_SWINT_1_SIGRETURN): New macro.
        (tilegx_write_pc): New function.
        (tilegx_cannot_reference_register): Return zero if REGNO
        is TILEGX_FAULTNUM_REGNUM.
        (tilegx_gdbarch_init): Add call to set_gdbarch_write_pc.
        (tilegx_register_name): Add handling of "faultnum" register.
        * tilegx-tdep.h (enum tilegx_regnum): Add TILEGX_FAULTNUM_REGNUM.
        * tilegx-linux-tdep.c (tilegx_linux_supply_regset): Add
        handling of TILEGX_FAULTNUM_REGNUM.
        * tilegx-linux-nat.c (regmap): Add entry for TILEGX_FAULTNUM_REGNUM.

The patch is approved with the above ChangeLog entry.

-- 
Joel