This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len'.
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 14 Feb 2013 17:14:04 +0000
- Subject: [COMMIT PATCH 1/2] savestring: Rename parameter 'size' to 'len'.
It's better to avoid needless confusion, and call a string's length,
length, instead of size, which is usually used to refer to sizeof of
the string (len+1):
size_t len = strlen (str);
size_t size = sizeof (str);
Tested on x86_64 Fedora 17.
2013-02-14 Pedro Alves <palves@redhat.com>
* utils.c (savestring): Rename parameter 'size' to 'len'.
---
gdb/utils.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/utils.c b/gdb/utils.c
index 282ab8b..408c6ce 100644
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -1186,17 +1186,17 @@ myread (int desc, char *addr, int len)
return orglen;
}
-/* Make a copy of the string at PTR with SIZE characters
+/* Make a copy of the string at PTR with LEN characters
(and add a null character at the end in the copy).
Uses malloc to get the space. Returns the address of the copy. */
char *
-savestring (const char *ptr, size_t size)
+savestring (const char *ptr, size_t len)
{
- char *p = (char *) xmalloc (size + 1);
+ char *p = (char *) xmalloc (len + 1);
- memcpy (p, ptr, size);
- p[size] = 0;
+ memcpy (p, ptr, len);
+ p[len] = 0;
return p;
}