This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RFC: invoke ACX_LARGEFILE for gdbserver


Fedora has been auditing programs that use stat without the large-file
support:

http://lists.fedoraproject.org/pipermail/devel/2013-February/178906.html

gdb itself is safe from this, but it turns out that gdbserver made it on
the list.

Here is one possible fix -- invoke ACX_LARGEFILE in gdbserver's
configure.ac.

This is perhaps not totally ideal, since it ties this to the BFD
"enable-plugin" option.  On the other hand, this is what gdb does and so
I chose it in the interests of keeping the two scripts more similar.

An alternative approach would be to directly invoke AC_SYS_LARGEFILE.

Comments?

Tom
    
    	* acinclude.m4: Include plugins.m4, largefile.m4.
    	* configure.ac: Invoke ACX_LARGEFILE.
    	* configure: Rebuild.

diff --git a/gdb/gdbserver/acinclude.m4 b/gdb/gdbserver/acinclude.m4
index 0e0bdc8..dd97bc1 100644
--- a/gdb/gdbserver/acinclude.m4
+++ b/gdb/gdbserver/acinclude.m4
@@ -12,6 +12,12 @@ sinclude(../../config/acx.m4)
 m4_include(../../config/depstand.m4)
 m4_include(../../config/lead-dot.m4)
 
+dnl This gets AC_PLUGINS, needed by ACX_LARGEFILE.
+m4_include(../../config/plugins.m4)
+
+dnl For ACX_LARGEFILE.
+m4_include(../../config/largefile.m4)
+
 dnl Check for existence of a type $1 in libthread_db.h
 dnl Based on BFD_HAVE_SYS_PROCFS_TYPE in bfd/bfd.m4.
 
diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
index 55fb461..bdd1565 100644
--- a/gdb/gdbserver/configure.ac
+++ b/gdb/gdbserver/configure.ac
@@ -27,6 +27,7 @@ AM_MAINTAINER_MODE
 
 AC_PROG_CC
 AC_GNU_SOURCE
+ACX_LARGEFILE
 
 AC_CANONICAL_SYSTEM
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]