This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] fix disassemble foo::bar::~bar
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 21 Feb 2013 14:14:10 -0700
- Subject: Re: [RFA] fix disassemble foo::bar::~bar
- References: <yjt2liarg3az.fsf@ruffy.mtv.corp.google.com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> I happened to try this and noticed it failing with
Doug> "name of destructor must equal name of class".
Doug> This is because destructor_name_p doesn't handle foo::bar
Doug> for the type's name.
Thanks for finding this.
Doug> + char *cp = strchr (type_name, '<');
I wonder whether this kind of parsing is sufficient.
It seems like there could be confounding cases.
I wonder what would happen if we just removed destructor_name_p,
or alternatively made it work by examining the type's function fields,
looking for a match.
If you've considered the various error cases in your analysis, then I
have no problem with your patch.
Tom