This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix complex argument handling in ppc64 dummy function call
- From: Pedro Alves <palves at redhat dot com>
- To: Tiago Stürmer Daitx <tdaitx at linux dot vnet dot ibm dot com>
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 01 Mar 2013 20:25:00 +0000
- Subject: Re: [PATCH] Fix complex argument handling in ppc64 dummy function call
- References: <20130301170811.EFEA2300943@igoo.rch.stglabs.ibm.com>
(not a real review, probably Ulrich would be
the best reviewer).
On 03/01/2013 05:08 PM, Tiago Stürmer Daitx wrote:
> + struct type *target_type;
> +
> + target_type = check_typedef (TYPE_TARGET_TYPE (type));
> + if (write_pass)
> + ppc64_sysv_abi_push_float (gdbarch, regcache, tdep,
While quickly skimming the patch I just noticed something wrong with
the indenting here.
> + target_type, val + i *
> + TYPE_LENGTH (target_type),
> + freg, greg, gparam);
> + freg += 2;
> + greg += 2;
> + gparam = align_up (gparam + TYPE_LENGTH (target_type),
> + tdep->wordsize);
> + }
--
Pedro Alves