This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix crash in read_pe_exported_syms


On Mar  4 09:41, Joel Brobecker wrote:
> > I really think that lots of 
> > 
> >   do_cleanup();
> >   return;
> > 
> > blocks are more error prone and less readable than a goto to a defined
> > label at the end of a function.  Are you really sure you want that?
> 
> Neither is obviously better, IMO, but the general style in GDB so far
> has been to call the cleanups before returning...

Ok.  Applied with that change.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]