This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix a bug in tstatus.exp matching tstatus output


On 03/05/2013 12:32 AM, Pedro Alves wrote:
On 03/04/2013 03:35 PM, Yao Qi wrote:
(gdb) PASS: gdb.trace/tstatus.exp: tstatus does not report trace stop reason
...
(gdb) PASS: gdb.trace/tstatus.exp: tstatus reports trace stop reason

I think the former (and any other similar case) should be UNSUPPORTED rather than a PASS. That'd make it much easier to spot these issues, along with regressions and progressions.

Several lines above, the comments say:

# Now play with tstatus a bit.
# Since note support is optional, we need to match both with and without
# cases.

so all tests below here match two cases (with and without notes). I am not sure we can change it to UNSUPPORTED, but it is not the purpose or motivation of this patch. It can be addressed separately.

--
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]