This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't need fast tracepoint in tstatus.exp


On 03/05/2013 04:51 AM, Yao Qi wrote:
> On 03/05/2013 12:46 AM, Pedro Alves wrote:
>>> tstatus.exp is used to test the output of 'tstatus' but there are some
>>>> tests on fast tracepoint in it, which is not related to tstatus.  This
>>>> patch is to remove these fast tracepoint related stuff from tstatus.exp.
>> Can we assume
>>
> 

I actually meant to delete that, sorry.

> The reason why fast tracepoint stuff was added into tstatus.exp is
> unclear to me.  It was not mentioned in the mail posting this patch.

Did you ask Stan?

>   However, I can't see how fast tracepoint affects the output of 
> 'tstatus', so I propose this patch to remove them.
> 
>> If we aren't doing any fast tracepoint tests, then is
>> there a reason to keep this prepare_for_testing and
>> runto_main instead of removing them altogether?
> 
> OK, the prepare_for_testing and runto_main are removed.

> 2013-03-05  Yao Qi  <yao@codesourcery.com>
>
> 	* gdb.trace/tstatus.exp: Remove the invocation to
> 	gdb_load_shlibs, gdb_compile, clean_restart and runto_main.

"invocation of"

> 	(test_tracepoints): Don't set fast tracepoint.
> 	(top level): Don't check agent library is loaded or not.

OK.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]