This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Constify gen_printf/ax_string
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 06 Mar 2013 20:11:30 +0000
- Subject: Re: [RFA] Constify gen_printf/ax_string
- References: <51379F85.4050005@redhat.com>
On 03/06/2013 07:56 PM, Keith Seitz wrote:
> Hi,
>
> As a follow-up to my "constify find_condition_and_thread" patch, which I am withdrawing, I will be submitting a patch to constify parse_exp_1. This patch is the only cleanup that I could split up off that (much larger) patch.
>
> Even if that approach is not liked/desired by maintainers, this patch has its own merit IMO.
I can't begin to imagine how to object to this one. :-)
> Tested by rebuilding (and testing on native-gdbserver, however fruitless that is on this type of patch).
> ChangeLog
> 2013-03-06 Keith Seitz <keiths@redhat.com>
>
> * ax-gdb.c (gen_printf): Make FORMAT const.
> * ax-gdb.h (gen_printf): Likewise.
> * ax-general.c (ax_string): Make STR const.
> * ax.h (ax_string): Likewise.
OK.
--
Pedro Alves