This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Compilation failure for mingw64 target (was New ARI warning Fri Mar 15 02:02:12 UTC 2013 in -D 2013-03-15-gmt)


> Yao>    /* Create DIRNAME.  */
> Yao> -  if (mkdir (dirname, S_IRWXU | S_IRGRP | S_IXGRP | S_IROTH |
S_IXOTH)
> Yao> -      && errno != EEXIST)
> Yao> +#ifdef USE_WIN32API
> Yao> +  ret = mkdir (dirname);
> Yao> +#else
> Yao> +  ret = mkdir (dirname, S_IRUSR | S_IWUSR | S_IXUSR);
> Yao> +#endif
> 
> I think S_IRUSR, S_IWUSR,and S_IXUSR are generally ok.
> At least, I see them unprotected in remote-fileio.c.
> So I think a simpler patch here would suffice, and would be cleaner
> besides.

  Tom, this second part is really about the fact that mkdir for
WIN32API doesn't have a second argument, contrary to the usual case.
See for instance Binutils/bucomm.c line 538.


Pierre Muller


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]