This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MinGW-w64]Build gdb/ctf.c failed
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: ktietz70 at googlemail dot com, asmwarrior at gmail dot com, tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 25 Mar 2013 10:38:38 +0200
- Subject: Re: [MinGW-w64]Build gdb/ctf.c failed
- References: <83ip4s4ixc dot fsf at gnu dot org> <1363407692-18959-1-git-send-email-yao at codesourcery dot com> <1363407692-18959-4-git-send-email-yao at codesourcery dot com> <CADPb22RwSq0iv_gQu5PSGezQoUy0ve16M2hmL51HvM19v0M5Ow at mail dot gmail dot com> <51492077 dot 30307 at codesourcery dot com> <83sj3qyogk dot fsf at gnu dot org> <87vc8m7z1d dot fsf at fleche dot redhat dot com> <514FA117 dot 9030604 at gmail dot com> <83hajz3oef dot fsf at gnu dot org> <CAEwic4Y020-LqwtNeYFXn3oQvk5fWBFm1T5ZoAmwqPSpD=PASg at mail dot gmail dot com> <515009B1 dot 5030500 at codesourcery dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 25 Mar 2013 16:24:17 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: Eli Zaretskii <eliz@gnu.org>, asmwarrior <asmwarrior@gmail.com>,
> <tromey@redhat.com>, <gdb-patches@sourceware.org>
>
> Right, 'mkdir' is declared io.h, which is included in unistd.h. Looks
> like we should use "mkdir" instead of "_mkdir". How about the patch
> below? It unbreaks the build of using mingw-w64 toolchain, while
> mingw32 toolchain doesn't complain about it.
I think you should "#undef mkdir" before redefining it, to be
absolutely safe here.
Other than that, I'm OK with this.