This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling
- From: Corinna Vinschen <vinschen at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 27 Mar 2013 12:13:01 +0100
- Subject: Re: [RFA] Fix cygwin32 failure introduced by [patch] windows-nat.c: Fix offset problem in signal string handling
- References: <20130319151436 dot GB20727 at calimero dot vinschen dot de> <20130319212554 dot GE4506 at adacore dot com> <000101ce2a6b$8c855a60$a5900f20$%muller at ics-cnrs dot unistra dot fr> <83y5d9xrqt dot fsf at gnu dot org> <005501ce2ac8$ae830150$0b8903f0$%muller at ics-cnrs dot unistra dot fr> <83obe5xgq2 dot fsf at gnu dot org>
- Reply-to: gdb-patches at sourceware dot org
On Mar 27 12:46, Eli Zaretskii wrote:
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Cc: <brobecker@adacore.com>, <gdb-patches@sourceware.org>, <vinschen@redhat.com>
> > Date: Wed, 27 Mar 2013 09:54:23 +0100
> >
> > ../../src/gdb/windows-nat.c: In function 'handle_output_debug_string':
> > ../../src/gdb/windows-nat.c:993:16: erreur: assignment makes pointer from integer without a cast
>
> Right. But IMO the casts here are dubious to begin with. strtoull
> produces a 64-bit value; casting it to a 32-bit uintptr_t might shut
This is really no problem. We know what value comes out of Cygwin.
It's a 32 bit pointer value on 32 bit and a 64 bit value on 64 bit,
so the cast is always right.
Please stop CCing me. I'm subscribed on the list and really don't
need the extra mail in my personal inbox. Thank you.
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat