This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 5/6] Move linux_find_memory_regions_full & co.
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Aleksandar Ristovski <aristovski at qnx dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 28 Mar 2013 21:13:47 +0100
- Subject: Re: [patch 5/6] Move linux_find_memory_regions_full & co.
- References: <51278984 dot 3070208 at qnx dot com> <20130310210831 dot GF21130 at host2 dot jankratochvil dot net> <514C56D0 dot 3020805 at qnx dot com> <20130326165839 dot GB12291 at host2 dot jankratochvil dot net> <515353C8 dot 5080100 at qnx dot com>
On Wed, 27 Mar 2013 21:17:12 +0100, Aleksandar Ristovski wrote:
> Moves should now be clean, without mods.
[...]
> @@ -3560,6 +3495,10 @@ target_fileio_read_alloc_1 (const char *filename,
> make_cleanup (free_current_contents, &memory_to_free);
> retval = read_alloc (buf_p, fd, target_fileio_read_alloc_1_pread, padding,
> &memory_to_free);
> + if (retval >= 0)
> + /* Returned allocated memory is interesting for the caller. */
> + memory_to_free = NULL;
The formatting according to GDB specific style in gdb/doc/gdbint.texinfo:
if (retval >= 0)
{
/* Returned allocated memory is interesting for the caller. */
memory_to_free = NULL;
}
> +
> do_cleanups (close_cleanup);
> return retval;
> }
This part should have been in the previous patch. No need to repost but
please rearrange it during the final check-in.
Jan