This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] dwarf2read.c: Remove complaint about missing .debug_types section.


Hi.
This complaint covers only one reason why the lookup may fail
so I'm removing it.  The callers will catch it.
[The callers currently call error() when they should call complaint()
but that's a separate issue.]

Committed.

2013-03-29  Doug Evans  <dje@google.com>

	* dwarf2read.c (lookup_signatured_type): Remove complaint about
	missing .debug_types section.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.764
diff -u -p -r1.764 dwarf2read.c
--- dwarf2read.c	29 Mar 2013 00:35:20 -0000	1.764
+++ dwarf2read.c	29 Mar 2013 16:38:12 -0000
@@ -4398,7 +4398,8 @@ create_all_type_units (struct objfile *o
 }
 
 /* Lookup a signature based type for DW_FORM_ref_sig8.
-   Returns NULL if signature SIG is not present in the table.  */
+   Returns NULL if signature SIG is not present in the table.
+   It is up to the caller to complain about this.  */
 
 static struct signatured_type *
 lookup_signatured_type (ULONGEST sig)
@@ -4406,12 +4407,7 @@ lookup_signatured_type (ULONGEST sig)
   struct signatured_type find_entry, *entry;
 
   if (dwarf2_per_objfile->signatured_types == NULL)
-    {
-      complaint (&symfile_complaints,
-		 _("missing `.debug_types' section for DW_FORM_ref_sig8 die"));
-      return NULL;
-    }
-
+    return NULL;
   find_entry.signature = sig;
   entry = htab_find (dwarf2_per_objfile->signatured_types, &find_entry);
   return entry;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]