Re: [PATCH] Fix dprintf work not right if it is pending

[Keith Seitz <keiths at redhat dot com>]

On 03/29/2013 12:42 AM, Hui Zhu wrote:

> > > +  breakpoint_re_set_default (b);
> > > +
> > > +  if (b->extra_string != NULL)
> > > +    update_dprintf_command_list (b);
> > > +}
> > > +
> >
> >
> > This will update the command list every time breakpoints are reset and could
> > be limited to only those needing updating. Is there perhaps a reason to
> > always do this?
>
> I think it need, because it need to generate different commands with
> different status for example:
>        if (target_can_run_breakpoint_commands ())
> 	printf_line = xstrprintf ("agent-printf %s", dprintf_args);

I'm not understanding this example. How is this likely to change 
whenever breakpoints are reset? Is there perhaps a way to add a test to 
demonstrate this requirement?

Otherwise, this patch looks good to me, and recommend that a maintainer 
give this a final review.

Keith