This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page))
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 12 Apr 2013 08:48:50 -0600
- Subject: Re: auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page))
- References: <20130407185443 dot GB15389 at host2 dot jankratochvil dot net> <83r4ilawlx dot fsf at gnu dot org> <20130408172841 dot GA28868 at host2 dot jankratochvil dot net> <87hajgua2o dot fsf at fleche dot redhat dot com> <516424FE dot 4050307 at redhat dot com> <20130409165525 dot GA29570 at host2 dot jankratochvil dot net> <51654DF0 dot 3090101 at redhat dot com> <20130410194910 dot GA3941 at host2 dot jankratochvil dot net> <20130411040309 dot GA20577 at host2 dot jankratochvil dot net> <5166923E dot 1070406 at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Jan> Forgot to state here were always replies one should strip all
Jan> auto-generated parts from posted patches - so I do it. But I find
Jan> that inconvenient. It is easier to skip a part of patch when
Jan> reviewing it than to regenerate it hopefully the same way as the
Jan> patch submitter because the source tree requires special autotools
Jan> (old version + unpatched).
Pedro> I fully agree. It's also very useful to see the generated bits
Pedro> to check whether a submitter who has commit/write access is using
Pedro> the right versions of the tools to regenerate the patches, and
Pedro> check whether the correct set of files is being regenerated.
I'm also not averse to changing this rule.
One drawback is that it would mean a different rule for gdb than for
other parts of the toolchain. But that is already true in various ways.
I'd like it if non-trivial series were available in git somewhere. Then
if someone really wanted to try the patch out it would be available
without re-applying.
Tom