This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] patch for review of PR gdb/10462
- From: mbilal <mbilal at codesourcery dot com>
- To: <palves at redhat dot com>, <hafiz_abid at mentor dot com>
- Cc: <gdb-patches at sourceware dot org>, <tromey at redhat dot com>, <schwab at suse dot de>
- Date: Wed, 17 Apr 2013 17:28:17 +0500
- Subject: Re: [patch] patch for review of PR gdb/10462
- References: <516D3B30 dot 6080501 at codesourcery dot com> <516E67FE dot 5070301 at codesourcery dot com>
On Wednesday, April 17, 2013 2:40 PM Abid, Hafiz wrote:
>I think you can break this line so that it does not go over 80 columns.
fixed.
On Wednesday, April 17, 2013 4:02 PM Pedro Alves wrote:
>How about putting the 'line' tests together?
fixed.
>I think it'd be good to test the reported case of using = instead of
space too.
fixed.
find attached updated patch.
Thanks,
-Bilal
Index: cli/cli-decode.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-decode.c,v
retrieving revision 1.118
diff -u -p -r1.118 cli-decode.c
--- cli/cli-decode.c 10 Apr 2013 15:11:12 -0000 1.118
+++ cli/cli-decode.c 17 Apr 2013 12:16:37 -0000
@@ -1556,6 +1556,9 @@ lookup_cmd (const char **line, struct cm
}
else
{
+ if (c->type == set_cmd && **line != '\0' && !isspace (**line))
+ error (_("Argument must be preceded by space."));
+
/* We've got something. It may still not be what the caller
wants (if this command *needs* a subcommand). */
while (**line == ' ' || **line == '\t')
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.15428
diff -u -p -r1.15428 ChangeLog
--- ChangeLog 17 Apr 2013 01:02:01 -0000 1.15428
+++ ChangeLog 17 Apr 2013 08:13:56 -0000
@@ -1,3 +1,9 @@
+2013-04-17 Muhammad Bilal <mbilal@codesourcery.com>
+
+ PR gdb/10462
+ * cli/cli-decode.c (lookup_command): Show an error if there is no space
+ before argument.
+
2013-04-17 Yao Qi <yao@codesourcery.com>
* top.c (print_gdb_configuration): Print configure-time
Index: gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.64
diff -u -p -r1.64 default.exp
--- gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64
+++ gdb.base/default.exp 17 Apr 2013 12:18:38 -0000
@@ -847,6 +847,13 @@ gdb_test "whatis" "The history is empty.
gdb_test "where" "No stack." "where"
#test x
gdb_test "x" "Argument required .starting display address.*" "x"
+#test argument must be preceded by space
+foreach x {"history file" "solib-search-path" "data-directory"} {
+ foreach y {"/home/" "." "~/home" "=home"} {
+ gdb_test "set $x$y" "Argument must be preceded by space." \
+ "check space before argument"
+ }
+}
gdb_exit
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.3628
diff -u -p -r1.3628 ChangeLog
--- ChangeLog 15 Apr 2013 20:37:36 -0000 1.3628
+++ ChangeLog 17 Apr 2013 08:23:11 -0000
@@ -1,3 +1,8 @@
+2013-04-17 Muhammad Bilal <mbilal@codesourcery.com>
+
+ PR gdb/10462
+ * gdb.base/default.exp: Add test case.
+
2013-04-15 Siva Chandra Reddy <sivachandra@google.com>
Add option to link testcases with Pthreads library when