This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] patch for review of PR gdb/10462
- From: Pedro Alves <palves at redhat dot com>
- To: mbilal <mbilal at codesourcery dot com>
- Cc: hafiz_abid at mentor dot com, gdb-patches at sourceware dot org, tromey at redhat dot com, schwab at suse dot de
- Date: Wed, 17 Apr 2013 13:54:35 +0100
- Subject: Re: [patch] patch for review of PR gdb/10462
- References: <516D3B30 dot 6080501 at codesourcery dot com> <516E67FE dot 5070301 at codesourcery dot com> <516E9561 dot 8090102 at codesourcery dot com>
On 04/17/2013 01:28 PM, mbilal wrote:
> --- gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64
> +++ gdb.base/default.exp 17 Apr 2013 12:18:38 -0000
BTW, is there a rationale for putting this in default.exp, which
is about default actions of commands? I think setshow.exp might make
more sense.
> +#test argument must be preceded by space
> +foreach x {"history file" "solib-search-path" "data-directory"} {
> + foreach y {"/home/" "." "~/home" "=home"} {
> + gdb_test "set $x$y" "Argument must be preceded by space." \
> + "check space before argument"
> + }
The uniqueness issue is still here:
http://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
Is there a reason
gdb_test_no_output "set $x $y" "set $x $y"
was removed in this version?
--
Pedro Alves