This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, mi] Add memory ranges to -library-loaded events


On 04/22/2013 11:59 AM, Luis Machado wrote:

> This patch extends the information exported by -library-loaded events to the upper layers by adding two more fields.
> 
> These fields are the low address and high address of the loaded library, indicating exactly where it was loaded in memory.

A library can have multiple segments, and they might well not be contiguous.

> I didn't see any explicit tests for -library-loaded events. We mostly just recognize that it is there, but ignore its contents completely. So no testcase for this one.
> 
> A NEWS entry was added and the documentation was updated to reflect the new fields.

These fields were present in the initial -library-loaded event
submission, but didn't pass review:

  http://sourceware.org/ml/gdb-patches/2009-02/msg00002.html

Please when pushing local patches always look up prior discussions and
refer to them.

As is, there doesn't seem to be any new justification to add
these new MI fields.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]