Re: RFC: close-on-exec internal file descriptors

[Yao Qi <yao at codesourcery dot com>]

Tom,
This patch causes a build regression with mingw32 cross gcc, reported 
here http://sourceware.org/ml/gdb-patches/2013-04/msg00682.html and I 
can reproduce it on my fedora 16:

i686-pc-mingw32-gcc -g -O2 -D__USE_MINGW_ACCESS   -I. -I../../../git/gdb 
-I../../../git/gdb/common -I../../../git/gdb/config 
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H 
-I../../../git/gdb/../include/opcode -I../../../git/gdb/../opcodes/.. 
-I../../../git/gdb/../readline/.. -I../bfd -I../../../git/gdb/../bfd 
-I../../../git/gdb/../include -I../libdecnumber 
-I../../../git/gdb/../libdecnumber -I./../intl 
-I../../../git/gdb/gnulib/import -Ibuild-gnulib/import    -Wall 
-Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral 
-Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch 
-Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement 
-Wempty-body -Wno-format -Werror -c -o filestuff.o -MT filestuff.o -MMD 
-MP -MF .deps/filestuff.Tpo ../../../git/gdb/common/filestuff.c
../../../git/gdb/common/filestuff.c:31:24: fatal error: sys/socket.h: No 
such file or directory

On 12/19/2012 01:44 AM, Tom Tromey wrote:
> 	* configure.ac: Don't check for sys/socket.h.  Check for
> 	fdwalk, closefrom, pipe2.

Your patch doesn't mention much on why not to check sys/socket.h. 
Probably we still need to check it.


--
Yao (éå)