This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent"
- From: Hui Zhu <teawater at gmail dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>, Marc Khouzam <marc dot khouzam at ericsson dot com>
- Date: Tue, 23 Apr 2013 11:41:50 +0800
- Subject: Re: [PATCH] Fix bug 15181 Missing continue on dprintf that defaults to "gdb" style from "agent"
- References: <CANFwon0wo7REDHb7FFk59Qoty_i_-NAwErFSQw7TZJWtqWNWrg at mail dot gmail dot com> <51748351 dot 2030300 at codesourcery dot com>
On Mon, Apr 22, 2013 at 8:24 AM, Yao Qi <yao@codesourcery.com> wrote:
> On 04/21/2013 07:06 PM, Hui Zhu wrote:
>>
>> This patch is from Marc to fix
>> http://sourceware.org/bugzilla/show_bug.cgi?id=15181
>> I add a test for it.
>
>
> Hui,
> I am afraid that it is not correct to append "continue" command to dprintf
> commands, considering PR 15075 dprintf inteferes with "next". This patch
> <http://sourceware.org/ml/gdb-patches/2013-02/msg00736.html> removes
> "continue" command from dprintf commands, and it is reasonable to remove
> "continue", IMO. The patch is not perfect, as it disallows users setting
> commands to dprintf, and I prefer to support commands in dprintf,
> personally.
>
> Since you are actively fixing dprintf bugs, feel free to take PR 15075 over,
> and fix it first. Then, PR 15181 may not be a bug at all.
The patch for remove "continue" is still in discussion, right?
So I think the patch from Marc is more easy to handle 15181. And it
will not affect new patches.
Thanks,
Hui
And
>
> --
> Yao (éå)