This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add -s option to make -break-insert support dprintf
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, Hui Zhu <hui_zhu at mentor dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Marc Khouzam <marc dot khouzam at ericsson dot com>
- Date: Wed, 24 Apr 2013 14:35:33 -0600
- Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
- References: <515451EA dot 1000200 at mentor dot com> <83y5d7wpvq dot fsf at gnu dot org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q at mail dot gmail dot com> <516454DA dot 9040109 at redhat dot com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig at mail dot gmail dot com> <87ppxzhfqy dot fsf at fleche dot redhat dot com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig at mail dot gmail dot com> <516C2549 dot 3060808 at redhat dot com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw at mail dot gmail dot com> <87vc7ithtj dot fsf at fleche dot redhat dot com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw at mail dot gmail dot com>
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> Does GDB have some function can convert string to "" inside string?
I wouldn't rule it out but I couldn't think of one offhand.
Hui> Could you give me some comments about the new format for -s.
Hui> My thought is:
Hui> -s format argv1 argv2, other options
Hui> "-break-insert -s FORMAT LOCATION ARG ARG ARG ..." is too different
Hui> with current options of -break-insert and very hard to support.
What is hard about it?
In mi_cmd_break_insert, if '-s' was given, use argv[oind+1] through
argv[argc-1] as the arguments. Maybe the hard part is getting this
through create_breakpoint? That is just further proof that it is a bad
API.
TBH I don't see why this needs to be in -break-insert. A new command
seems cleaner to me. But I don't want to press too hard either.
Tom