This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ANNOUNCEMENT] GDB 7.6 released!


> > The offending incomplete type is 'enum errors'.
> 
> Any reason not to include exceptions.h in utils.h, to avoid these
> warnings?

No objection from me. We'd then be able to remove the partial
declaration of that enum.

A few additional thoughts:

I am wondering why we are not seeing this on other platforms...

utils.c:throw_perror_with_name doesn't appear to be used anywhere except
in utils.c:perror_with_name, which is nothing more than a wrapper where
errcode is set to GENERIC_ERROR. I am wondering if we want to keep that
function around, or either make the function static, or inline its code
in perror_with_name...

I'd probably investigate why and when the function was introduced
before making a decision, but I am running out of time for today...

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]