This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/4] code changes for Nios II target, version 3
- From: Pedro Alves <palves at redhat dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org, Eli Zaretskii <eliz at gnu dot org>
- Date: Mon, 06 May 2013 10:13:57 +0100
- Subject: Re: [patch 1/4] code changes for Nios II target, version 3
- References: <517481E7 dot 7030608 at codesourcery dot com> <20130426063617 dot GO3525 at adacore dot com> <51833147 dot 8090206 at codesourcery dot com> <5183FD41 dot 2040501 at redhat dot com> <5185C06E dot 6010800 at codesourcery dot com>
On 05/05/2013 03:14 AM, Sandra Loosemore wrote:
> On 05/03/2013 12:09 PM, Pedro Alves wrote:
>>
>> It looks pretty good to me too.
>>
>> The new new xml target features need to be documented in
>> the manual though, as well as the new command(s).
>>
>> A NEWS entry is necessary as well.
>
> OK, fixed.
Thanks. Eli, could you take a look at those, please?
>> A few minor nits below.
>
> These are fixed now too.
>
> Thanks for the review! I think I've been staring at this code too long.... it's gotten hard to see how stupid some of this stuff is. :-S
:-)
> Latest version of patch attached. Ready to commit now?
The code parts are okay. Please go ahead once Eli's approved
the docs bits.
--
Pedro Alves