This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/4] code changes for Nios II target, version 3


On 05/05/2013 03:14 AM, Sandra Loosemore wrote:
> On 05/03/2013 12:09 PM, Pedro Alves wrote:
>>
>> It looks pretty good to me too.
>>
>> The new new xml target features need to be documented in
>> the manual though, as well as the new command(s).
>>
>> A NEWS entry is necessary as well.
> 
> OK, fixed.

Thanks.  Eli, could you take a look at those, please?

>> A few minor nits below.
> 
> These are fixed now too.
> 
> Thanks for the review!  I think I've been staring at this code too long....  it's gotten hard to see how stupid some of this stuff is.  :-S

:-)

> Latest version of patch attached.  Ready to commit now?

The code parts are okay.  Please go ahead once Eli's approved
the docs bits.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]