This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] record: make record goto begin/end sub-commands
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Mon, 06 May 2013 20:37:49 +0300
- Subject: Re: [PATCH] record: make record goto begin/end sub-commands
- References: <1367849454-22941-1-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 6 May 2013 16:10:54 +0200
>
> The "record goto" command scans its arguments for "begin", "start", or "end".
> Turn those into sub-commands.
>
> Document the "record goto" command.
Thanks.
> +@table @code
> +@item record goto begin
> +@item record goto start
> +Go to the beginning of the execution log.
You want @itemx on the second item.
> +@item record goto @var{insn}
> +Go to instruction number @var{insn} in the execution log.
I think it's better to use @var{n} to indicate that it is a number.
OK with those changes.