This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for PR 15413 (segfault when completing "condition" for pending bp)


On 05/06/2013 09:57 PM, Sergio Durigan Junior wrote:

> So, if I understood your brain dump correctly, you're suggesting that
> the "condition" command shouldn't complete multiple locations at all,
> since the condition is inherent to the breakpoint, not to the
> location(s).  Is that right?  I will submit a patch soon.

Yes.  The patch to do that should be quite trivial,
mostly just removing/simplifying code, and it should fix the
segfault too as consequence, so I'd prefer focusing on a patch
that did that first (over trying to fix the existing bogus
multi-location code),

> [OTOH, I guess it would make more sense if the condition were a location
> property.]

and leave this for a separate discussion.  The patch should then
be quite safe for 7.6 backporting too.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]