This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix file name matching in expand_symtabs_matching_via_partial
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 9 May 2013 00:22:04 +0200
- Subject: Re: [RFA] Fix file name matching in expand_symtabs_matching_via_partial
- References: <yjt2vc6txnsz dot fsf at ruffy2 dot mtv dot corp dot google dot com>
On Wed, 08 May 2013 21:40:44 +0200, Doug Evans wrote:
> The test
> (basenames_may_differ
> || (*file_matcher) (lbasename (ps->filename), data, 1))
> fails and the code falls through assuming the file name matched.
I agree and your new code with "match" is more clear.
[...]
> + if (! match)
^^^^
### if (!match)
GDB Coding Style.
Sorry,
Jan