This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: History saving should stay disabled for test cases


Thanks, that looks much better!

> +2013-05-09  Muhammad Bilal  <mbilal@codesourcery.com>
> +
> +       * gdb.base/default.exp: Disabled history saving.

No past tense:

s/Disabled/Disable/

> +       * gdb.base/setshaow.exp: likewise.

typo, setshow.exp.

Note that the standard is to include the ChangeLog entry
in plain text in the body of the email instead of including
it in the patch.

Please go ahead and commit.  It'd be great if you put the
subject+rationale in the commit log, as well as the (fixed)
ChangeLog entry, so that it's just a cvs log / git log away.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]