This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Cleanup for make_source_files_completion_list
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Thu, 09 May 2013 14:58:38 -0600
- Subject: Re: [RFC] Cleanup for make_source_files_completion_list
- References: <51895A2F dot 8000504 at redhat dot com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> make_source_files_completion_list is only ever called with the first
Keith> parameter twice, e.g.,
Keith> fn_list = make_source_files_completion_list (text, text);
Keith> Is there any reason to not whack the second parameter as the following
Keith> patch does?
It makes me wonder if those calls are wrong somehow.
But if those calls are correct then the patch is ok.
Tom