This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: close-on-exec internal file descriptors
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 May 2013 11:00:27 -0600
- Subject: Re: RFC: close-on-exec internal file descriptors
- References: <874njjs1aa dot fsf at fleche dot redhat dot com> <m2vcbzui0o dot fsf at igel dot home> <87fw32p00e dot fsf at fleche dot redhat dot com> <874niy6y35 dot fsf at fleche dot redhat dot com> <87d2tmsey0 dot fsf at fleche dot redhat dot com> <20130501144722 dot GA10034 at adacore dot com> <874negym65 dot fsf at fleche dot redhat dot com> <20130507064559 dot GI5278 at adacore dot com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I tested the patches, and they look good to me, except for the fact
Joel> that we were missing the #include of filestuff.h. Attached is patch
Joel> that builds and tests fine on x86_64-darwin and ia64-hpux...
Thanks Joel.
I'm checking this in with this ChangeLog:
2013-05-10 Joel Brobecker <brobecker@adacore.com>
Tom Tromey <tromey@redhat.com>
* common/filestuff.c (mark_fd_no_cloexec, unmark_fd_no_cloexec):
New functions.
* common/filestuff.c (mark_fd_no_cloexec, unmark_fd_no_cloexec):
Declare.
* darwin-nat.c (darwin_pre_ptrace): Use mark_fd_no_cloexec.
(darwin_ptrace_him): Use unmark_fd_no_cloexec.
* inf-ttrace.c (do_cleanup_pfds): Use unmark_fd_no_cloexec.
(inf_ttrace_prepare): Use mark_fd_no_cloexec.
Tom