This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add -s option to make -break-insert support dprintf


Hi Eli,

Thanks for your review.

On Sat, May 11, 2013 at 3:28 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Hui Zhu <teawater@gmail.com>
>> Date: Sat, 11 May 2013 10:37:56 +0800
>> Cc: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>, Hui Zhu <hui_zhu@mentor.com>,
>>       gdb-patches ml <gdb-patches@sourceware.org>, Marc Khouzam <marc.khouzam@ericsson.com>
>>
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -60,6 +60,8 @@ show debug nios2
>>    ** The -trace-save MI command can optionally save trace buffer in Common
>>       Trace Format now.
>>
>> +  ** The new command -dprintf-insert sets a dynamic printf breakpoint.
>> +
>>  *** Changes in GDB 7.6
>
> This part is OK.
>
>> +If specified, @var{location}, can be one of:
>> +
>> +@itemize @bullet
>> +@item function
>> +@c @item +offset
>> +@c @item -offset
>> +@c @item linenum
>> +@item filename:linenum
>> +@item filename:function
>> +@item *address
>> +@end itemize
>
> Each of "function", "filename", "linenum", and "address" above
> should be in @var{}, because they do not stand for themselves.

Fixed.

>
>> +If @var{location} cannot be parsed (for example if it
>                                                   ^
> A comma is missing.

The comma is after the right parenthesis: refers to unknown files or functions),
Do I need change this part to following format?
If @var{location} cannot be parsed, (for example if it
refers to unknown files or functions) create a pending


>
>> +refers to unknown files or functions), create a pending
>> +breakpoint. Without this flag, @value{GDBN} will report
>              ^^
> Two spaces between sentences.

Fixed.

>
>> +@item -i @var{ignore-count}
>> +Initialize the @var{ignore-count}.
>
> "Set the ignore count of the breakpoint (@pxref{Conditions, ignore
> count}) to @var{ignore-count}."
>
>> +Note: this format is open to change.
>
> Why do we need this note in the manual?

Removed.

>
>> +The corresponding @value{GDBN} commands are @samp{dprintf}.
>                                   ^^^^^^^^^^^^
> "command is"

Fixed.

Post a new version according to your comments.

Thanks,
Hui

2013-05-13  Hui Zhu  <hui@codesourcery.com>

	* breakpoint.c (dprintf_breakpoint_ops): Remove its static.
	* breakpoint.h (dprintf_breakpoint_ops): Add extern.
	* mi/mi-cmd-break.c (ctype.h): New include.
	(gdb_obstack.h): New include.
	(mi_argv_to_format, mi_cmd_break_insert_1): New.
	(mi_cmd_break_insert): Call mi_cmd_break_insert_1.
	(mi_cmd_dprintf_insert): New.
	* mi/mi-cmds.c (mi_cmds): Add "dprintf-insert".
	* mi/mi-cmds.h (mi_cmd_dprintf_insert): New extern.

2013-05-13  Hui Zhu  <hui@codesourcery.com>

	* gdb.texinfo (GDB/MI Breakpoint Commands): Describe the
	"-dprintf-insert" command.

2013-05-13  Hui Zhu  <hui@codesourcery.com>

	* gdb.mi/Makefile.in (PROGS): Add "mi-dprintf".
	* gdb.mi/mi-dprintf.exp, gdb.mi/mi-dprintf.c: New.

Attachment: mi-dprintf.txt
Description: Text document

Attachment: mi-dprintf-doc.txt
Description: Text document

Attachment: mi-dprintf-test.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]