This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 39/40] fix compile_rx_or_error
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 13 May 2013 08:59:29 -0600
- Subject: Re: [PATCH 39/40] fix compile_rx_or_error
- References: <cover dot 1368124285 dot git dot tromey at redhat dot com> <b742ab349892cce15df6d761190d17eb27a23976 dot 1368124285 dot git dot tromey at redhat dot com> <519055B5 dot 10803 at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>> - if (!rx)
>> - return NULL;
>> -
Yao> Do we need an assert on RX here?
It can't hurt, but I think the subsequent regcomp will just crash.
I will add one.
Tom