This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add -s option to make -break-insert support dprintf
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: Pedro Alves <palves at redhat dot com>, Eli Zaretskii <eliz at gnu dot org>, Hui Zhu <hui_zhu at mentor dot com>, gdb-patches ml <gdb-patches at sourceware dot org>, Marc Khouzam <marc dot khouzam at ericsson dot com>
- Date: Mon, 13 May 2013 10:23:09 -0600
- Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
- References: <515451EA dot 1000200 at mentor dot com> <83y5d7wpvq dot fsf at gnu dot org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q at mail dot gmail dot com> <516454DA dot 9040109 at redhat dot com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig at mail dot gmail dot com> <87ppxzhfqy dot fsf at fleche dot redhat dot com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig at mail dot gmail dot com> <516C2549 dot 3060808 at redhat dot com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw at mail dot gmail dot com> <87vc7ithtj dot fsf at fleche dot redhat dot com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw at mail dot gmail dot com> <87wqrrll9m dot fsf at fleche dot redhat dot com> <CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ at mail dot gmail dot com> <87d2t2tt02 dot fsf at fleche dot redhat dot com> <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg at mail dot gmail dot com> <87ehdehnc9 dot fsf at fleche dot redhat dot com> <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA at mail dot gmail dot com>
>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:
Hui> 2013-05-11 Hui Zhu <hui@codesourcery.com>
Hui> * breakpoint.c (dprintf_breakpoint_ops): Remove its static.
Hui> * breakpoint.h (dprintf_breakpoint_ops): Add extern.
Hui> * mi/mi-cmd-break.c (ctype.h): New include.
Hui> (gdb_obstack.h): New include.
Hui> (mi_argv_to_format, mi_cmd_break_insert_1): New.
Hui> (mi_cmd_break_insert): Call mi_cmd_break_insert_1.
Hui> (mi_cmd_dprintf_insert): New.
Hui> * mi/mi-cmds.c (mi_cmds): Add "dprintf-insert".
Hui> * mi/mi-cmds.h (mi_cmd_dprintf_insert): New extern.
Hui> 2013-05-11 Hui Zhu <hui@codesourcery.com>
Hui> * gdb.texinfo (GDB/MI Breakpoint Commands): Describe the
Hui> "-dprintf-insert" command.
Hui> 2013-05-11 Hui Zhu <hui@codesourcery.com>
Hui> * gdb.mi/Makefile.in (PROGS): Add "mi-dprintf".
Hui> * gdb.mi/mi-dprintf.exp, gdb.mi/mi-dprintf.c: New.
The code bits are ok.
Thanks.
Tom