This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bug 15433 - GDB crashes when using agent dprintf, %s format, and an in-line string


>>>>> "Hui" == Hui Zhu <teawater@gmail.com> writes:

Hui> +	      if (aexpr == NULL)
Hui> +		error (_("Agent is not support commands of breakpoint %d."),
Hui> +		       bl->owner->number);

In addition to what Yao said, this change seems roughly equivalent to
simply removing the TRY_CATCH from parse_cmd_to_aexpr.  (You'd have to
clear loc->cmd_bytecode first, but it seems to me that this has to be
done anyway, because parse_cmd_to_aexpr can already call error...)

I also still don't understand the code to set null_command_or_parse_error.
Maybe you explained it to me last time, but I forget.  If it is actually
correct as-is, I would appreciate a comment explaining it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]