This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux)
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 May 2013 14:14:08 -0600
- Subject: Re: [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux)
- References: <20130514191026 dot 13213 dot 39574 dot stgit at brno dot lan> <20130514191054 dot 13213 dot 58686 dot stgit at brno dot lan>
Pedro> + /* Note that all addresses are always "out the step range" when
Pedro> + there's no range to begin with. */
I think "out of the step range".
Pedro> + else if (p[0] == 'r')
Pedro> + {
Pedro> + char *p1;
Pedro> +
Pedro> + p = p + 1;
Pedro> + p1 = strchr (p, ',');
Pedro> + decode_address (&resume_info[i].step_range_start, p, p1 - p);
Pedro> +
Pedro> + p = p1 + 1;
Pedro> + p1 = strchr (p, ':');
Pedro> + decode_address (&resume_info[i].step_range_end, p, p1 - p);
Pedro> +
Pedro> + p = p1;
Pedro> + }
I don't know much about gdbserver, but reading this made me wonder if it
needs to do any kind of error-checking on its input.
Like - what if the wrong format is sent, or if the range end is before
the range start?
Tom