This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/7] range stepping: gdb
- From: Yao Qi <yao at codesourcery dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 15 May 2013 16:07:16 +0800
- Subject: Re: [PATCH 4/7] range stepping: gdb
- References: <1363006291-13334-1-git-send-email-yao at codesourcery dot com> <1363006291-13334-5-git-send-email-yao at codesourcery dot com> <51928303 dot 3050407 at redhat dot com>
On 05/15/2013 02:31 AM, Pedro Alves wrote:
This is problematic. It's better to_not_ have target itself decide
when to range step or to single step, and peeking at "infrun-owned"
variables. For example, with software watchpoints, GDB needs to have control
of single-steps, in order to evaluate the watchpoints at after each
instruction is executed, so trap_expected isn't enough. (My v3 adds a test for
that, that v2 fails.)
I didn't take software watchpoint into account in V2, so probably some
problems there.
I dislike the design of using PC checks here too :-/. That
seems fragile, and potentially inefficient (considering GDB ever
sending more than one range action per packet, that might end up
fetching registers for threads unnecessarily). IMO, it's better to have
Sorry, I don't understand why it is inefficient.
--
Yao (éå)